Skip to content

Conversation

@dashkan
Copy link

@dashkan dashkan commented Aug 18, 2017

Allows targeting electron renderer using the new platform property in .angular-cli.json.

Happy to add wiki story for the use case.

This resolves issue #5767

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@dashkan
Copy link
Author

dashkan commented Aug 18, 2017

Changed my GH primary email to match CLA email address

@dashkan dashkan closed this Aug 18, 2017
@dashkan dashkan changed the title Support electron renderer as a platform feat(@angular/cli): platform-electron-renderer Aug 18, 2017
@dashkan dashkan reopened this Aug 18, 2017
@hansl
Copy link
Contributor

hansl commented Aug 18, 2017

You're going to need to create a new PR entirely.

@dashkan dashkan closed this Aug 18, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants